Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slider breaking when inside a Section Column #2291

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: slider breaking when inside a Section Column #2291

merged 1 commit into from
Jul 30, 2024

Conversation

HardeepAsrani
Copy link
Member

Closes https://github.com/Codeinwp/otter-internals/issues/190.

Summary

This fixes the issue with Slider not working properly in the editor when added inside the Section's Column.

Screenshots

Test instructions

  • Add a section block with 2 columns
  • In the first column, add a slider block
  • In the second one, add a paragraph block
  • Save and check the page
  • Also, adjust the column width and check again

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 29, 2024
@HardeepAsrani HardeepAsrani changed the base branch from master to development July 29, 2024 22:13
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 29, 2024
@HardeepAsrani HardeepAsrani changed the title Fix/issue 190 fix: slider breaking when inside a Section Column Jul 29, 2024
@HardeepAsrani
Copy link
Member Author

@AndreeaCristinaRadacina Can you confirm it works properly for you now?

@pirate-bot
Copy link
Contributor

Plugin build for c495d9f is ready 🛎️!

@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 239.1 KB 264.29 KB 25.19 KB (10.53%)
Blocks 1.5 MB 1.52 MB 22.69 KB (1.48%)
CSS 93.17 KB 93.54 KB 369 B (0.39%)
Dashboard 201.53 KB 195.83 KB -5.7 KB (-2.83%)
Onboarding 154.18 KB 153.95 KB -230 B (-0.15%)
Export Import 90.95 KB 91.01 KB 65 B (0.07%)
Pro 355.91 KB 362.24 KB 6.34 KB (1.78%)

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 238.9, firstPaint: 145.85, domContentLoaded: 1550.75, loaded: 1551.4, firstContentfulPaint: 3503.75, firstBlock: 6801.5, type: 13.63, minType: 11.39, maxType: 16.41, typeContainer: 8.46, minTypeContainer: 7.46, maxTypeContainer: 9.26, focus: 32.56, minFocus: 28.98, maxFocus: 40.34, inserterOpen: 24.04, minInserterOpen: 21.06, maxInserterOpen: 28.99, inserterSearch: 0.69, minInserterSearch: 0.61, maxInserterSearch: 0.75, inserterHover: 4.12, minInserterHover: 3.37, maxInserterHover: 5.4, listViewOpen: 150.2, minListViewOpen: 136.6, maxListViewOpen: 164.54

@HardeepAsrani HardeepAsrani merged commit 31f05e6 into development Jul 30, 2024
14 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-190 branch July 30, 2024 18:33
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HardeepAsrani @pirate-bot